Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels/Billboards behind the camera appear in the wrong position when minimumDisableDepthTestDistance is Infinity #5331

Closed
denverpierce opened this issue May 16, 2017 · 12 comments · Fixed by #5735

Comments

@denverpierce
Copy link
Contributor

Gist

This happens when scene.minimumDisableDepthTestDistance is set to Number.POSITIVE_INFINITY, when viewing Labels/Billboard/Points at angles low to the Horizon and reasonably close to the entities.

Entities behind the camera will render in the wrong position.
s

@pjcozzi
Copy link
Contributor

pjcozzi commented May 18, 2017

Thanks for the report, @denverpierce!

@bagnell is this an easy fix? Perhaps you could guide @rahwang?

@oterral
Copy link

oterral commented Jun 21, 2017

I'm interested to fix this if someone can give me guidance

@oterral
Copy link

oterral commented Jun 21, 2017

It happens not only with INFINITY value, but whatever the value I put .

@hpinkos
Copy link
Contributor

hpinkos commented Jun 21, 2017

Thanks for volunteering @oterral! @bagnell do you have any suggestions here?

@rahwang
Copy link
Contributor

rahwang commented Jul 11, 2017

Does anyone have any ideas about what this might be? I'd really like to get this fixed soon, since it pops up in my workshop app. @bagnell , any clue? I'd be happy to work on this.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 11, 2017

@rahwang do you want to experiment with the shader? See this part: https:/AnalyticalGraphicsInc/cesium/blob/master/Source/Shaders/BillboardCollectionVS.glsl#L259-L276

@hpinkos
Copy link
Contributor

hpinkos commented Aug 10, 2017

@denverpierce @oterral this issue was fixed in #5735 and will be included in the 1.37 release available on September 1st. Thanks!

@denverpierce
Copy link
Contributor Author

Did you mean #5735?

@hpinkos
Copy link
Contributor

hpinkos commented Aug 10, 2017

uh, yes! Thanks @denverpierce =)

@oterral
Copy link

oterral commented Aug 14, 2017

good thx for the fix !!!!

@thw0rted
Copy link
Contributor

I don't know if this was missing before, but right now disableDepthTestDistance is missing from the constructor options in the docs.

@hpinkos
Copy link
Contributor

hpinkos commented Oct 20, 2017

Thanks @thw0rted! I submitted a PR to update the doc #5918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants