-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LabelCollection incorrectly caches clamped position when re-using #5338
Labels
Comments
Definitely a billboard bug, here's a simpler reproduction: var viewer = new Cesium.Viewer('cesiumContainer');
var billboards = new Cesium.BillboardCollection({scene: viewer.scene});
viewer.scene.primitives.add(billboards);
var b = billboards.add({
position : Cesium.Cartesian3.fromDegrees(-75, 45),
image : '../images/facility.gif',
heightReference : Cesium.HeightReference.CLAMP_TO_GROUND
});
Sandcastle.addToolbarButton('Set position', function(){
b.position = Cesium.Cartesian3.ZERO;
}); |
mramato
added a commit
that referenced
this issue
May 18, 2017
Clear the current clamped position if the new position is not clampable. Fixes #5338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The below code:
abc
, with a position clamped to ground.Step 1
, it removes the labelStep 2
, it adds a new label,abcd
, without a position.The bug is that the second label should not be displayed (because it has no position), but the first 3 letters shows up at the first removed label's position because the glyphs still have a value for
_actualClampedPosition
. I'm not sure if this is a bug inLabelCollection
or a bug inBillboardCollection
being exposed via label usage.The text was updated successfully, but these errors were encountered: