-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebMapServiceImageryProvider clobbers srs option #6223
Comments
Thanks @tamarmot! If you have a chance, we'd be happy to take another PR with this fix =) |
Yep, I'll be looking into this soon now that I know the process!
…On Thu, Feb 15, 2018 at 7:18 AM, Hannah ***@***.***> wrote:
Thanks @tamarmot <https:/tamarmot>! If you have a chance,
we'd be happy to take another PR with this fix =)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6223 (comment)>,
or mute the thread
<https:/notifications/unsubscribe-auth/AFgK8C_YZCYAvGtHFe6t0jUEkfuBgmKkks5tVEqhgaJpZM4SGMmA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If, theoretically, one were using a different SRS, such as one for the moon, and wanted to pass that through to a WMS via the WebMapServiceImageryProvider, there is currently no way to do so as this is hardcoded as follows:
// Use SRS or CRS based on the WMS version.
if (parseFloat(resource.queryParameters.version) >= 1.3) {
// Use CRS with 1.3.0 and going forward.
// For GeographicTilingScheme, use CRS:84 vice EPSG:4326 to specify lon, lat (x, y) ordering for
// bbox requests.
parameters.crs = options.tilingScheme instanceof WebMercatorTilingScheme ? 'EPSG:3857' : 'CRS:84';
} else {
// SRS for WMS 1.1.0 or 1.1.1.
parameters.srs = options.tilingScheme instanceof WebMercatorTilingScheme ? 'EPSG:3857' : 'EPSG:4326';
}
It would be a simple thing to check for the srs parameter in the options, and use that instead.
The text was updated successfully, but these errors were encountered: