Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

globe.cartographicLimitRectangle can't be unset #7477

Closed
lilleyse opened this issue Jan 10, 2019 · 2 comments
Closed

globe.cartographicLimitRectangle can't be unset #7477

lilleyse opened this issue Jan 10, 2019 · 2 comments

Comments

@lilleyse
Copy link
Contributor

If you try setting globe.cartographicLimitRectangle to undefined after it has previously been set, it will crash.

crash

Sandcastle

@likangning93 any ideas?

@likangning93
Copy link
Contributor

The shipped Sandcastle demo treats the "deactivation" case as Rectangle.MAX_VALUE, which is default.
Under-the-hood GlobeSurfaceTileProvider always checks tiles against the limiter rectangle but only modifies shaders for terrain tiles that intersect, so the default of Rectangle.MAX_VALUE shouldn't cause any shader modification.

I think it's the right level of abstraction to modify the setter in Globe.js so setting undefined percolates a Rectangle.MAX_VALUE down.

@lilleyse
Copy link
Contributor Author

That approach makes sense. Also cartographicLimitRectangle seems to be missing documentation - #6987 (comment). It would be good to fix that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants