-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cesium3DTileStyle.style is not reactive #7567
Comments
@bkuster I can't see any reason for not updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Issue
If a
Cesium3DTileStyle
is created, its options are used to populate the readonlystyle
property, which is described by the docs as follows:This is not the case, since
style.style
is only evaluated at style creation. Thus the following fails, making cloning & persisting of styles tedious:Proposed Solution
When setting an expression on the style, the
getExpression
function not only receivesthis.style
andvalue
but alsokey
. The key is then set onthis.style
to reflect the current value. You can see an implementation of this solution here, I would gladly open a PR for this.The text was updated successfully, but these errors were encountered: