-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when loading glTF's KHR_texture_transform without a sampler #7916
Labels
Comments
So it looks like the behavior is to have repeatS/repeatT be false if there's no sampler? |
No, the default wrapping value in glTF is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cesium's implementation of the
KHR_texture_transform
extension of glTF makes poor assumptions that the optionalsampler
will be defined.https:/AnalyticalGraphicsInc/cesium/blob/90b130edea858b7b6b6a1575422b0b2654f2ae97/Source/Scene/processPbrMaterials.js#L94
In the above,
gltf.samplers
need not be defined, andgltf.textures[n].sampler
is likewise optional, leading to a rather fancy message:Here's a sample model for testing.
TexRotateTest.zip
The text was updated successfully, but these errors were encountered: