Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong type definition for EllipsoidTangentPlane.fromPoints #8926

Closed
zoran995 opened this issue Jun 7, 2020 · 2 comments · Fixed by #8928
Closed

Wrong type definition for EllipsoidTangentPlane.fromPoints #8926

zoran995 opened this issue Jun 7, 2020 · 2 comments · Fixed by #8928
Labels
category - doc category - typescript

Comments

@zoran995
Copy link
Contributor

zoran995 commented Jun 7, 2020

Hi,
function fromPoints in EllipsoidTangentPlane has wrong type definition
source code
doc
@OmarShehata
Copy link
Contributor

Thanks for reporting @zoran995 . I can see that its input is stated as Cartesian3 when it should be an array of Cartesian3.

CC @mramato

@mramato
Copy link
Contributor

mramato commented Jun 7, 2020

Thanks, will fix this ASAP and it will be out with 1.70.1 later this week.

@mramato mramato mentioned this issue Jun 7, 2020
Merged
@zoran995 zoran995 mentioned this issue Nov 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - doc category - typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Two small JSDoc/TS fixes CesiumGS/cesium
3 participants
@mramato @OmarShehata @zoran995