Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing a simple skinned model exported from Blender and then going through the Collada-glTF converter, I noticed a bug with the skeleton generation.
When searching for a joint in
searchForest
, it loops through the children of the runtime node. The problem is the runtime nodes don't have children yet, sincecreateSkins
comes beforecreateRuntimeNodes
increateResources
.The solution I have loops over the children of the gltf node instead of the runtime node. Another solution is to change the order of calls in
createResources
, but I was worried this would create unintended problems. Or maybe the runtime node's children should be set inparseNodes
.The reason this wasn't noticed before is our Cesium guy lists all its joints in the
skeletons
property, sosearchForest
never had to loop over children.