Scene.pickPosition in 2D/CV

[bagnell]

Adds pick position support in 2D and Columbus view. Fixes #4084.

• Tests
• Update CHANGES.md

[pjcozzi]

This exception is not longer valid, right?

[pjcozzi]

Perhaps it would be more clear to name this pickPosition3D and make it @private.

[pjcozzi]

Or whatever a more precise name is.

[pjcozzi]

Can we also document that the results can be different in 2D vs. 3D/CV due to the orthographic projection and give some sense as to how the precision works?

For example, in 3D:

In 2D:

[bagnell]

@pjcozzi This is ready for another look.

[pjcozzi]

Do you get this test failure?

Scene/Scene pickPosition
Expected Cartesian3({ x: -455845.5482883507, y: -5210338.458916779, z: 3637550.496413719 }) to equal epsilon Cartesian3({ x: -455845.46867895435, y: -5210337.548977215, z: 3637549.8562320103 }), 1e-7.
Error: Expected Cartesian3({ x: -455845.5482883507, y: -5210338.458916779, z: 3637550.496413719 }) to equal epsilon Cartesian3({ x: -455845.46867895435, y: -5210337.548977215, z: 3637549.8562320103 }), 1e-7.
    at stack (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1475:17)
    at buildExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1445:14)
    at Spec.expectationResultFactory (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:584:18)
    at Spec.addExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:332:34)
    at Expectation.addExpectationResult (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:528:21)
    at Expectation.toEqualEpsilon (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1399:12)
    at http://localhost:8080/Specs/Scene/SceneSpec.js:660:30
    at compare (http://localhost:8080/Specs/addDefaultMatchers.js:255:29)
    at Expectation.toRenderAndCall (http://localhost:8080/ThirdParty/jasmine-2.2.0/jasmine.js:1378:35)
    at http://localhost:8080/Specs/Scene/SceneSpec.js:658:23

[bagnell]

Do you get this test failure?

I was not seeing any failures. I changed the test to check the values returned instead of that it was defined. I updated the epsilon values so they should pass now.

[pjcozzi]

Very nice.