make headingPitchRoll to quaternion counter clock wise #5079
Conversation
|
Thanks for submitting this @kaktus40! I agree that we should probably be using counter clockwise rotation, but this would be a breaking change for a lot of people so we'll need to discuss how we want to approach this. |
|
@kaktus40 thanks again, and sorry for the long delay; this has been sitting in my queue. Does this require any doc changes or updates to any of the Sandcastle examples, including the development ones? Seems like it would. As @hpinkos mentioned, even though this doesn't break the API it is still a breaking change that I suspect will break some apps so we would need to come up with a deprecation plan (see Deprecation and Breaking Changes). |
|
Hi @kaktus40, I would suggest creating new functions for the new conversations and deprecating the old ones. Also please merge in master. |
|
Hello, I can't work on this pull request until september. Nevertheless, I can read your suggestions!
|
|
@kaktus40 Is it OK if we close this PR for now and move this to an issue until you're ready to work on this again? We'd still appreciate your contributions! |
|
From the time this PR is opened, I don't think that adding two months change something :-). I'm not a pro of git but if the PR is closed, should I make a new branch or an update on the branch reopen the PR?
|
|
Your branch will remain in your fork of cesium, and you can work on it there. You can re-open this PR when it's ready to go. I've open #5666 so we don't forget! |
|
It's ok for me to close in this condition
|
Hello,
just to follow this topic, I made a pull request to make the conversions between heading pitch roll and quaternion counter clock wise oriented (mathematical convention).