Add options.query to KMLDataSource

[ottaviohartman]

Fixes #5408

Pass around a query parameter which eventually gets blobbed onto the various uri in KMLDataSource. I've added like 6 unit tests, but am unconvinced about the thoroughness of this implementation. @mramato please test elsewhere? :)

One problem: using proxyUrl to append query means that processNetworkLinkQueryString will be using the already-formatted href (LINE). Therefore, it will be used throughout the text-replacement process of processNetworkLinkQueryString. I don't think this will (ever) be a problem, unless some authentication token contains [bboxWest] or something.

I've also moved a function call out of an if block, so now the behavior is that proxyUrl is run for every URI. This is ok because if either proxy or query are undefined, proxyUrl doesn't do anything.

Ottavio

[mramato]

This still needs to be inside of an if (!hrefResolved) block, so adjust the original logic to handle that. Basically, if hrefResolved is true at this point, it means that the item is a data or blob uri, which means we can't/shouldn't append query parameters to it.

[mramato]

At first glance, this looks perfect and that was the only comment I had. Also update CHANGES (just edit the CZML line from your last PR).

I'll put this through its paces and take a deeper look and let you know if I find any problems.

Thanks @omh1280!

[mramato]

processBillboardIcon needs to be passed a copy of the query (which means it needs to be threaded through apply style as well. (it also means you have at least one missing test to cover that code.)

[mramato]

You forgot to take this out (always try and remember to npm run eslint before each commit/push)

[ottaviohartman]

Fixed, thanks

[mramato]

Awesome work here @omh1280! Thanks.