Added debug label for tile url #5592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lilleyse
commented
Jul 6, 2017
lilleyse
commented
lilleyse
commented
Jul 6, 2017
| */ | ||
| this.debugShowMemoryUsage = defaultValue(options.debugShowMemoryUsage, false); | ||
|
|
||
| /** |
There was a problem hiding this comment.
Maybe due to a bad merge all these properties had been duplicated, but are removed now.
|
@ggetz can you review this? |
ggetz
reviewed
Jul 7, 2017
| }); | ||
| /** | ||
| * Gets or sets the flag to show tile url. This property is observable. | ||
| * |
There was a problem hiding this comment.
We only need @memberof when the property is added using defineProperties. So it can probably be removed from the doc of all of these since they're directly on this
|
@lilleyse That's all I have. I assume CHANGES.md still needs to be updated with the new debug option. |
|
Updated. |
|
Thanks @lilleyse |
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.