Frustum geometry #5649
Frustum geometry #5649
Conversation
|
Submitted #5651 |
|
|
||
| var frustumGeometry = new Cesium.FrustumGeometry({ | ||
| frustum : frustum, | ||
| position : positionOnEllipsoid, |
There was a problem hiding this comment.
I guest position is good since it is consistent with the rest of the Cesium API; I wonder if there is something better in the context of frustum like viewer or origin (e.g., we use origin for a ray, not position).
Can you look around and come up with the best name?
| Cesium.Matrix3.multiply(rotation, Cesium.Matrix3.fromRotationX(-Cesium.Math.PI_OVER_TWO), rotation); | ||
| var orientation = Cesium.Quaternion.fromRotationMatrix(rotation); | ||
|
|
||
| var frustum = new Cesium.PerspectiveFrustum(); |
There was a problem hiding this comment.
Does this have an options constructor we can use?
| * @constructor | ||
| * | ||
| * @param {Object} options Object with the following properties: | ||
| * @param {PerspectiveFrustum|OrthographicFrustum} options.frustum The frustum. |
There was a problem hiding this comment.
Is it easy to compute the input to a box geometry given an orthographic frustum? If so, perhaps this should only take a perspective frustum and be renamed.
There was a problem hiding this comment.
Sure, but I think it's simpler this way.
Source/Core/FrustumGeometry.js
Outdated
| var orientation = options.orientation; | ||
| var position = options.position; | ||
| var vertexFormat = defaultValue(options.vertexFormat, VertexFormat.DEFAULT); | ||
| var drawNearPlane = defaultValue(options._drawNearPlane, true); |
There was a problem hiding this comment.
Add a comment about why this is private...or I wonder if we would want it to be public.
| * @alias FrustumOutlineGeometry | ||
| * @constructor | ||
| * | ||
| * @param {Object} options Object with the following properties: |
| * @param {Cartesian3} options.position The position of the frustum. | ||
| * @param {Quaternion} options.orientation The orientation of the frustum. | ||
| */ | ||
| function FrustumOutlineGeometry(options) { |
There was a problem hiding this comment.
Is it possible for this to share any code with FrustumGeometry since all the positions are the same?
Or is that more trouble than it is worth?
| @@ -246,7 +246,7 @@ define([ | |||
| array[startingIndex++] = value.st ? 1.0 : 0.0; | |||
| array[startingIndex++] = value.tangent ? 1.0 : 0.0; | |||
| array[startingIndex++] = value.bitangent ? 1.0 : 0.0; | |||
| array[startingIndex++] = value.color ? 1.0 : 0.0; | |||
| array[startingIndex] = value.color ? 1.0 : 0.0; | |||
|
Is there anywhere else that needs to be updated, e.g., is this used at all for 3D Tiles or terrain debugging? |
No, it's only |
|
@pjcozzi This is ready for another look. |
|
Very nice! |
Adds
FrustumGeometryandFrustumOutlineGeometry