Use associative array key type for entity collection ids

[gberaudo]

The previous type: Object is too broad, thus not compatible with the associative array key: String|Number.

As a side note, I noticed the documentation is broken: click on the link to the source code of https://cesiumjs.org/Cesium/Build/Documentation/EntityCollection.html#getById and you will get a 404 error.

[cesium-concierge]

@gberaudo, thanks for the pull request! Maintainers, we have a signed CLA from @gberaudo, so you can review this at any time.

I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I am a bot who helps you make Cesium awesome! Thanks again.

[ggetz]

Hi @gberaudo, thanks for the pull request!

According to the Entity.id docs, id should be a string exclusively.

Would you also mind updating the docs for the other EnityCollection functions that take an id as a parameter, likegetById(id)?

[gberaudo]

Thanks for fixing the documentation links.
Sure, I will look at this.

[gberaudo]

I looked at other places and only found an issue in CompositeEntityCollection, which is now also fixed.

[ggetz]

Thanks @gberaudo! Can you also update CHANGES.md? Once that's done this is ready to go.

[gberaudo]

OK @ggetz, done.

[ggetz]

Thanks @gberaudo !

@pjcozzi This is ready to merge.

[pjcozzi]

Thanks @gberaudo @ggetz!