Clipping planes support cleanup #6084
Conversation
|
@ggetz, thanks for the pull request! Maintainers, we have a signed CLA from @ggetz, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
| * @param {Number} [options.colorBlendAmount=0.5] Value used to determine the color strength when the <code>colorBlendMode</code> is <code>MIX</code>. A value of 0.0 results in the model's rendered color while a value of 1.0 results in a solid color, with any value in-between resulting in a mix of the two. | ||
| * @param {Color} [options.silhouetteColor=Color.RED] The silhouette color. If more than 256 models have silhouettes enabled, there is a small chance that overlapping models will have minor artifacts. | ||
| * @param {Number} [options.silhouetteSize=0.0] The size of the silhouette in pixels. | ||
| * @param {ClippingPlaneCollection} [options.clippingPlanes] The {@link ClippingPlaneCollection} used to selectively disable rendering the model. Clipping planes are not currently supported in Internet Explorer. |
There was a problem hiding this comment.
Thanks... I didn't realize so many options were missing.
| * | ||
| * @returns {Boolean} <code>true</code> if ClippingPlaneCollections are supported; otherwise, returns <code>false</code> | ||
| */ | ||
| ClippingPlaneCollection.isSupported = function() { |
There was a problem hiding this comment.
Does this warrant an update to CHANGES.md, or too minor? @pjcozzi?
There was a problem hiding this comment.
Anything that changes the public API always warrants a CHANGEs.md update.
|
Thanks @lilleyse, updated CHANGES.md. |
|
Looks good. |
Addresses @lilleyse 's comments in #6079