Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using Cesium inside of Electron apps. #6726

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Fix using Cesium inside of Electron apps. #6726

merged 2 commits into from
Jun 25, 2018

Conversation

mramato
Copy link
Contributor

@mramato mramato commented Jun 23, 2018

Our Node.js detection was imperfect and unnecessary, we should have been checking for the existence of XMLHttpRequest instead.

Fixes #6671

Our Node.js detection was imperfect and unnecessary, we should have been
checking for the existence of `XMLHttpRequest` instead.

Fixes #6671
@cesium-concierge
Copy link

Signed CLA is on file.

@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos
Copy link
Contributor

hpinkos commented Jun 25, 2018

Looks great, thanks @mramato!

@hpinkos hpinkos merged commit 92b3dea into master Jun 25, 2018
@hpinkos hpinkos deleted the fix-electron branch June 25, 2018 15:25
@lbize
Copy link

lbize commented Jul 13, 2018

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants