Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Improve jsdoc tags for tsd-jsdoc integration #6899

Merged
merged 12 commits into from
Dec 14, 2018
4 changes: 2 additions & 2 deletions Source/Core/BingMapsGeocoderService.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ define([
/**
* The URL endpoint for the Bing geocoder service
* @type {String}
* @memberof {BingMapsGeocoderService.prototype}
* @memberof BingMapsGeocoderService.prototype
* @readonly
*/
url : {
Expand All @@ -56,7 +56,7 @@ define([
/**
* The key for the Bing geocoder service
* @type {String}
* @memberof {BingMapsGeocoderService.prototype}
* @memberof BingMapsGeocoderService.prototype
* @readonly
*/
key : {
Expand Down
3 changes: 3 additions & 0 deletions Source/Core/DoublyLinkedList.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ define([
}
});

/**
* @private
*/
function DoublyLinkedListNode(item, previous, next) {
this.item = item;
this.previous = previous;
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/EarthOrientationParameters.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ define([
* Gets a promise that, when resolved, indicates that the EOP data has been loaded and is
* ready to use.
*
* @returns {Promise.<undefined>} The promise.
* @returns {Promise} The promise.
*
* @see when
*/
Expand Down
1 change: 0 additions & 1 deletion Source/Core/Event.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ define([
*
* @alias Event
* @constructor
*
* @example
* MyObject.prototype.myListener = function(arg1, arg2) {
* this.myArg1Copy = arg1;
Expand Down
1 change: 1 addition & 0 deletions Source/Core/Fullscreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ define([
* Browser-independent functions for working with the standard fullscreen API.
*
* @exports Fullscreen
* @namespace
*
* @see {@link http://dvcs.w3.org/hg/fullscreen/raw-file/tip/Overview.html|W3C Fullscreen Living Specification}
*/
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/Iau2006XysData.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ define([
* the Terrestrial Time (TT) time standard.
* @param {Number} stopSecondTT The seconds past noon of the end of the interval to preload, expressed in
* the Terrestrial Time (TT) time standard.
* @returns {Promise.<undefined>} A promise that, when resolved, indicates that the requested interval has been
* @returns {Promise} A promise that, when resolved, indicates that the requested interval has been
* preloaded.
*/
Iau2006XysData.prototype.preload = function(startDayTT, startSecondTT, stopDayTT, stopSecondTT) {
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/IauOrientationAxes.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ define([
*
* @param {JulianDate} date The date to evaluate the matrix.
* @param {Matrix3} result The object onto which to store the result.
* @returns {Matrix} The modified result parameter or a new instance of the rotation from ICRF to Fixed.
* @returns {Matrix3} The modified result parameter or a new instance of the rotation from ICRF to Fixed.
*/
IauOrientationAxes.prototype.evaluate = function(date, result) {
if (!defined(date)) {
Expand Down
1 change: 1 addition & 0 deletions Source/Core/IntersectionTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ define([
* Functions for computing the intersection between geometries such as rays, planes, triangles, and ellipsoids.
*
* @exports IntersectionTests
* @namespace
*/
var IntersectionTests = {};

Expand Down
3 changes: 3 additions & 0 deletions Source/Core/MapboxApi.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ define([
defined) {
'use strict';

/**
* @exports MapboxApi
*/
var MapboxApi = {};

/**
Expand Down
13 changes: 0 additions & 13 deletions Source/Core/OrientedBoundingBox.js
Original file line number Diff line number Diff line change
Expand Up @@ -250,19 +250,6 @@ define([

var scratchOffset = new Cartesian3();
var scratchScale = new Cartesian3();
/**
* Computes an OrientedBoundingBox given extents in the east-north-up space of the tangent plane.
*
* @param {Plane} tangentPlane The tangent place corresponding to east-north-up.
* @param {Number} minimumX Minimum X extent in tangent plane space.
* @param {Number} maximumX Maximum X extent in tangent plane space.
* @param {Number} minimumY Minimum Y extent in tangent plane space.
* @param {Number} maximumY Maximum Y extent in tangent plane space.
* @param {Number} minimumZ Minimum Z extent in tangent plane space.
* @param {Number} maximumZ Maximum Z extent in tangent plane space.
* @param {OrientedBoundingBox} [result] The object onto which to store the result.
* @returns {OrientedBoundingBox} The modified result parameter or a new OrientedBoundingBox instance if one was not provided.
*/
function fromTangentPlaneExtents(tangentPlane, minimumX, maximumX, minimumY, maximumY, minimumZ, maximumZ, result) {
//>>includeStart('debug', pragmas.debug);
if (!defined(minimumX) ||
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/PeliasGeocoderService.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ define([
/**
* The Resource used to access the Pelias endpoint.
* @type {Resource}
* @memberof {PeliasGeocoderService.prototype}
* @memberof PeliasGeocoderService.prototype
* @readonly
*/
url: {
Expand Down
5 changes: 3 additions & 2 deletions Source/Core/Request.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@ define([
*
* @alias Request
* @constructor
*
* @namespace
* @exports Request
* @param {Object} [options] An object with the following properties:
* @param {Boolean} [options.url] The url to request.
* @param {String} [options.url] The url to request.
* @param {Request~RequestCallback} [options.requestFunction] The function that makes the actual data request.
* @param {Request~CancelCallback} [options.cancelFunction] The function that is called when the request is cancelled.
* @param {Request~PriorityCallback} [options.priorityFunction] The function that is called to update the request's priority, which occurs once per frame.
Expand Down
18 changes: 5 additions & 13 deletions Source/Core/Simon1994PlanetaryPositions.js
Original file line number Diff line number Diff line change
Expand Up @@ -333,11 +333,7 @@ define([
var Sl8 = -80 * 1e-7;

var scratchDate = new JulianDate(0, 0.0, TimeStandard.TAI);
/**
* Gets a point describing the motion of the Earth-Moon barycenter according to the equations
* described in section 6.
*/

// Gets a point describing the motion of the Earth-Moon barycenter according to the equations described in section 6.
function computeSimonEarthMoonBarycenter(date, result) {

// t is thousands of years from J2000 TDB
Expand Down Expand Up @@ -375,9 +371,7 @@ define([
longitudeOfNode, meanLongitude, result);
}

/**
* Gets a point describing the position of the moon according to the equations described in section 4.
*/
// Gets a point describing the position of the moon according to the equations described in section 4.
function computeSimonMoon(date, result) {
taiToTdb(date, scratchDate);
var x = (scratchDate.dayNumber - epoch.dayNumber) + ((scratchDate.secondsOfDay - epoch.secondsOfDay)/TimeConstants.SECONDS_PER_DAY);
Expand Down Expand Up @@ -481,11 +475,9 @@ define([
longitudeOfNode, meanLongitude, result);
}

/**
* Gets a point describing the motion of the Earth. This point uses the Moon point and
* the 1992 mu value (ratio between Moon and Earth masses) in Table 2 of the paper in order
* to determine the position of the Earth relative to the Earth-Moon barycenter.
*/
// Gets a point describing the motion of the Earth. This point uses the Moon point and
// the 1992 mu value (ratio between Moon and Earth masses) in Table 2 of the paper in order
// to determine the position of the Earth relative to the Earth-Moon barycenter.
var moonEarthMassRatio = 0.012300034; // From 1992 mu value in Table 2
var factor = moonEarthMassRatio / (moonEarthMassRatio + 1.0) * -1;
function computeSimonEarth(date, result) {
Expand Down
2 changes: 1 addition & 1 deletion Source/Core/TimeIntervalCollection.js
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ define([
* The data property of the input interval is ignored.
*
* @param {TimeInterval} interval The interval to remove.
* @returns <code>true</code> if the interval was removed, <code>false</code> if no part of the interval was in the collection.
* @returns {Boolean} <code>true</code> if the interval was removed, <code>false</code> if no part of the interval was in the collection.
*/
TimeIntervalCollection.prototype.removeInterval = function(interval) {
//>>includeStart('debug', pragmas.debug);
Expand Down
3 changes: 2 additions & 1 deletion Source/Core/Transforms.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ define([
* Contains functions for transforming positions to various reference frames.
*
* @exports Transforms
* @namespace
*/
var Transforms = {};

Expand Down Expand Up @@ -487,7 +488,7 @@ define([
* indicates that the preload has completed.
*
* @param {TimeInterval} timeInterval The interval to preload.
* @returns {Promise.<undefined>} A promise that, when resolved, indicates that the preload has completed
* @returns {Promise} A promise that, when resolved, indicates that the preload has completed
* and evaluation of the transformation between the fixed and ICRF axes will
* no longer return undefined for a time inside the interval.
*
Expand Down
1 change: 0 additions & 1 deletion Source/Core/binarySearch.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ define([
* Finds an item in a sorted array.
*
* @exports binarySearch
*
* @param {Array} array The sorted array to search.
* @param {*} itemToFind The item to find in the array.
* @param {binarySearch~Comparator} comparator The function to use to compare the item to
Expand Down
1 change: 0 additions & 1 deletion Source/Core/mergeSort.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ define([
* A stable merge sort.
*
* @exports mergeSort
*
* @param {Array} array The array to sort.
* @param {mergeSort~Comparator} comparator The function to use to compare elements in the array.
* @param {*} [userDefinedObject] Any item to pass as the third parameter to <code>comparator</code>.
Expand Down
1 change: 1 addition & 0 deletions Source/Core/writeTextToCanvas.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ define([
* @returns {Canvas} A new canvas with the given text drawn into it. The dimensions object
* from measureText will also be added to the returned canvas. If text is
* blank, returns undefined.
* @exports writeTextToCanvas
*/
function writeTextToCanvas(text, options) {
//>>includeStart('debug', pragmas.debug);
Expand Down
2 changes: 1 addition & 1 deletion Source/DataSources/GroundGeometryUpdater.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ define([
/**
* An abstract class for updating ground geometry entities.
* @constructor
*
* @alias GroundGeometryUpdater
* @param {Object} options An object with the following properties:
* @param {Entity} options.entity The entity containing the geometry to be visualized.
* @param {Scene} options.scene The scene where visualization is taking place.
Expand Down
28 changes: 4 additions & 24 deletions Source/DataSources/KmlTour.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,26 +106,15 @@ define([
cancelAllEntries(this._activeEntries);
};

/**
* Stop all activeEntries.
* @param {Array} activeEntries
*/
// Stop all activeEntries.
function cancelAllEntries(activeEntries) {
for(var entry = activeEntries.pop(); entry !== undefined; entry = activeEntries.pop()) {
entry.stop();
}
}

/**
* Play playlist entry.
* This function is called recursevly with playNext
* and iterates over all entries from playlist.
*
* @param {ViewerWidget} viewer Cesium viewer.
* @param {Object} cameraOptions see {@link Camera#flyTo}.
* @param {Function} allDone a function will be called when all entries from playlist
* being played or user call {@link KmlTour#stop}.
*/
// Play playlist entry.
// This function is called recursevly with playNext and iterates over all entries from playlist.
function playEntry(viewer, cameraOptions, allDone) {
var entry = this.playlist[this.playlistIndex];
if (entry) {
Expand All @@ -152,16 +141,7 @@ define([
}
}

/**
* Increment playlistIndex and call playEntry
* if terminated isn't true.
*
* @param {ViewerWidget} viewer passed for recursion.
* @param {Object} cameraOptions passed for recursion.
* @param {Function} allDone passed for recursion.
* @param {Boolean} terminated true if active entry was terminated,
* and the whole tour should be terminated.
*/
// Increment playlistIndex and call playEntry if terminated isn't true.
function playNext(viewer, cameraOptions, allDone, terminated) {
var entry = this.playlist[this.playlistIndex];
this.entryEnd.raiseEvent(entry, terminated);
Expand Down
3 changes: 3 additions & 0 deletions Source/Renderer/CubeMap.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ define([
TextureMinificationFilter) {
'use strict';

/**
* @private
*/
function CubeMap(options) {
options = defaultValue(options, defaultValue.EMPTY_OBJECT);

Expand Down
3 changes: 3 additions & 0 deletions Source/Renderer/Texture.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ define([
TextureMinificationFilter) {
'use strict';

/**
* @private
*/
function Texture(options) {
options = defaultValue(options, defaultValue.EMPTY_OBJECT);

Expand Down
Loading