HeightReference for Box, Cylinder and Ellipsoid #6932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @hpinkos!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
mramato
reviewed
Aug 20, 2018
| position: Cesium.Cartesian3.fromDegrees(west, north, 0.0), | ||
| box : { | ||
| dimensions : new Cesium.Cartesian3(40.0, 30.0, 50.0), | ||
| material : Cesium.Color.fromRandom({alpha : 1}), |
There was a problem hiding this comment.
The outlines look pretty bad to me because of the opaqunesss, can we set alpha .9 here and add .withAlpha(0.9) to the outlineCloud below? (or just get of outlines).
There was a problem hiding this comment.
I didn't like the way that looked, so I removed the outlines instead
mramato
reviewed
Aug 20, 2018
Source/DataSources/BoxGraphics.js
Outdated
| @@ -72,6 +74,14 @@ define([ | |||
| } | |||
| }, | |||
|
|
|||
| /** | |||
| * Gets or sets the Property specifying the {@link HeightReference}. | |||
| * @memberof EllipsoidGraphics.prototype | |||
mramato
reviewed
Aug 20, 2018
| @@ -84,6 +86,14 @@ define([ | |||
| } | |||
| }, | |||
|
|
|||
| /** | |||
| * Gets or sets the Property specifying the {@link HeightReference}. | |||
| * @memberof EllipsoidGraphics.prototype | |||
|
Just those comments, like the look of the updated demo. Thanks @hpinkos! |
|
@mramato ready for another look |
|
Thanks @hpinkos! One step closer to terrain by default! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6777
Adds
heightReferenceproperty toBoxGraphics,CylinderGraphicsandEllipsoidGraphicswhich can be used to clamp these geometry types to terrain.