Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7032
This was a regression from #6957 at this commit 259c314. That turned off translucent object sorting during the pick pass. I must have been thinking pick commands wrote depth but they currently don't.
One fix is to revert that commit, the other is to write depth for pick commands. This PR does the second. I like the second way because it makes the pick pass more accurate for overlapping primitives, and allows pick functions to get a pick id and the pick position in the same pass, which I'm trying to do to optimize the pick-from-ray functions. It does break some
PrimitiveCollection
tests where it expects primitives added at the same spot to be picked based on the order they were added. I'm not sure if this is the test being too strict or actually important behavior to preserve. @bagnell do you know?Only broken in master so no CHANGES.md update needed.Edit: does happen in earlier versions of Cesium. Needs CHANGES.md update.