Add the ability to cut out a Rectangle from ImageryLayers #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @likangning93!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
likangning93
force-pushed
the
imageryCutoutRectangle
branch
from
e998f8b
to
d241e0c
Compare
|
@likangning93 This looks good to me. Can you merge in master? |
|
@bagnell merged in master |
bagnell
reviewed
Oct 10, 2018
| @@ -573,13 +573,13 @@ defineSuite([ | |||
| switchViewMode(SceneMode.SCENE3D, new GeographicProjection(Ellipsoid.WGS84)); | |||
|
|
|||
| return updateUntilDone(scene.globe).then(function() { | |||
| expect(scene).toRender([0, 0, 127, 255]); // default baseColor | |||
| expect(scene).toRender([0, 0, 128, 255]); // default baseColor | |||
There was a problem hiding this comment.
This test is failing for me. The result is 127, not 128.
There was a problem hiding this comment.
Hmmm, I swear it was passing on Windows/Linux on my Intel system, but now I'm seeing the same thing on Windows + Nvidia. Either way, poorly designed spec...
|
@bagnell this is up-to-date! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to cut out a
RectanglefromImageryLayers.A caveat that I feel needs defense: this doesn't influence imagery tile selection. The intent was for this
Rectangleto be dynamic, and it looked to me like getting this to function with the existing imagery tile selection code would have been pretty complicated. Let me know if I was wrong and I should fix that.Besides this just being kind of a fun feature, we likely need this to implement #6531.
Client-side mosaics and client-side imagery reprojection, both of which need to preserve pixel detail, will probably require doing something like generating high detail imagery for small areas on-the-fly and drawing it over low-detail "placeholder" imagery that covers the entire mosaic area.
The layers can be transparent, so layering them directly on top of each other isn't acceptable.