Update gltf-pipeline and fix model test #7206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
lilleyse
force-pushed
the
fix-model-test
branch
from
0ed6e95
to
deecce6
Compare
|
@ggetz can you review? |
|
@ggetz Can you check this out soon? It would be nice to get this into the release. |
|
The CI failure seems to be #7207 related. |
|
This all looks good to me. All the tests pass locally. Just waiting for CI to pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7205
Nodes containing extensions or extras where being removed in the glTF 1.0 to 2.0 upgrade stage. This was removing nodes that represented light sources with the
KHR_materials_commonextension. The test is now the same as it was originally written.The gltf-pipeline fix is here: CesiumGS/gltf-pipeline#431