Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion here: #7361 (comment)
This renames
ModelAnimation.speedup
toModelAnimation.timeMultiplier
and adds a deprecation warning that it will be removed in one more version. I kept the old property and added a@deprecated
doc tag. I also tweaked the doc HTML slightly to make sure there's a newline after the deprecated statement so that it looks better.I was initially going to just call it
ModelAnimation.rate
but that felt like it was referring to "Frame rate" but glTF animations are based on real time, not a fixed frame rate. I thought aboutscale
ortimeScale
but just went withtimeMultiplier
because I it made the most sense to me.@hpinkos @lilleyse do either of you want to review?