Ground primitives and textured entities on 3D Tiles #7434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on if there are no 3D Tiles commands
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Merged
|
@likangning93 can you review the primitive changes and @bagnell the |
likangning93
approved these changes
Dec 23, 2018
|
👍 at quick glance! |
mramato
reviewed
Jan 2, 2019
CHANGES.md
Outdated
| * Fixed an issue where classification primitives with the `CESIUM_3D_TILE` classification type would render on terrain. | ||
| * Fixed an issue where 3D Tiles would show through the globe. | ||
|
|
||
| ##### Breaking Changes :mega: |
There was a problem hiding this comment.
Breaking changes should go first, before everything else.
bagnell
approved these changes
Jan 2, 2019
|
More CI timeouts. I restarted the build. |
|
Well the previous commit passes, so I think this is fine. The last commit was CHANGES.md only. |
That's why I merged it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #7422 and adds support for ground primitives and textured entities on 3D Tiles.
The default classification type is now
ClassificationType.BOTHeverywhere.locahost demo