New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodeTransformations documentation #7464

Merged

hpinkos merged 1 commit into CesiumGS:master from OmarShehata:patch-8

Jan 7, 2019

Contributor

OmarShehata commented Jan 5, 2019

I lost a fair bit of time wondering why this isn't working until I realized the docs were wrong.


Fix nodeTransformations documentation

cesium-concierge commented Jan 5, 2019

Thanks for the pull request @OmarShehata!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.
❔ Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

hpinkos merged commit b1ac5e2 into CesiumGS:master

OmarShehata mentioned this pull request

Realistic vehicle wheel speed Sandcastle example #7361

Merged

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment