New Bing Maps Styles - AerialWithLabelsOnDemand and RoadOnDemand. #7808
Conversation
…d imagery sets. Cherry-picked from downstream fork, TerriaJS/cesium.
|
Thanks for the pull request @KeyboardSounds!
Reviewers, don't forget to make sure that:
|
|
I work with @kring at Data61, so I'm covered by their CLA. |
|
Thanks @KeyboardSounds. I added you to our CLA bot. Could you please also submit a separate issue for someone to remove the deprecated features in a future Cesium release? |
@pjcozzi I don't think there's any real reason to remove |
|
Gotcha, that is OK with me, thanks. |
| }); | ||
|
|
||
| describe('shouldDiscardImage', function() { | ||
| fit('does not discard a non-empty image', function() { |
There was a problem hiding this comment.
fit snuck into the committed code here, which disables all other tests. (this sort of thing is why fit should just not exist in Jasmine, in my opinion)
There was a problem hiding this comment.
fit and fdescribe are really helpful if you just need to debug one new test. However, in some of our other repos we added a custom eslint rule to catch it so it would break CI if you committed it. Maybe we should add that to this repo too
There was a problem hiding this comment.
The spec filtering can run single tests or suites without needing to edit the source, e.g.:
http://localhost:8080/Specs/SpecRunner.html?spec=Core%2FappendForwardSlash%20Appends%20to%20a%20url
There was a problem hiding this comment.
That doesn't work if you need to run it from the command line to reproduce an error that only happens in travis
There was a problem hiding this comment.
our custom web client is honestly crazy
There was a problem hiding this comment.
Doesn't our eslint configuraton flag fit/fdescribe? It does everywhere else outside of Cesium.
There was a problem hiding this comment.
No, I'm pretty sure it's just in the eslintrc.json for specific projects
There was a problem hiding this comment.
Play. We should definitely fix that then, I'll open a PR soon-ish
There was a problem hiding this comment.
How embarrassing, good catch. 😳
|
This all looks good. I may build on this to fix #1353 as well, since the |
|
I fixed the few minor things I mentioned and merged this to master. Thanks! |
Adds support for new Bing Maps imagery styles RoadOnDemand and AerialWithLabelsOnDemand. The other versions of these, Road and AerialWithLabels, have been deprecated.
Fixes #7128.