Fix missing wall segments for some extruded polygons #8035
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating vertices and indices for extruded polygons, we only generate indices for vertices that aren't too close together. However, the array that we were allocating for these indices was sometimes too small, which was most apparent with rhumbline polygons like geojson. This PR allocates a larger array up-front and slices it down to size after all indices have been generated.
I'm not 100% sure how the original index count was computed, @hpinkos @lilleyse is any of that familiar?