Fix blending states #8202
Merged
Fix blending states #8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
lilleyse
force-pushed
the
fix-blending-state
branch
from
7dd4e36
to
460984c
Compare
|
Looks good @lilleyse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blending equation for the alpha channel was incorrect in master. It would end up doing
srcAlpha * srcAlpha + dstAlpha * (1.0 - srcAlpha)After the fix the equation is
srcAlpha * 1.0 + dstAlpha * (1.0 - srcAlpha)Also fixed
ADDITIVE_BLENDwhich had the same problem.Noticed while working on #4381. I guess it never came up before because we never alpha blend a framebuffer onto another framebuffer.