Added pixelRatio parameter to camera and the frustum objects #8237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another CSS pixel fix for #8113
All frustums have a
getPixelDimensions
function that didn't account for different pixel density displays. So this PR adds a newpixelRatio
parameter to these functions. Most systems should pass inframeState.pixelRatio
to get a value in css pixels. This fixes a few different files that use minimum/maximum pixel size, includingBillboardCollection
,Model
,Primitive
, andPointPrimtiveCollection
. This before and after are particularly noticeable on high dpi displays. Toggle the resolution checkbox. In the new version the model stays the same size.Note:
Picking.getPickOrthographicCullingVolume
andPicking.getPickPerspectiveCullingVolume
pass in1.0
instead ofscene.pixelRatio
because picking wants to select from a physically smaller region on higher density screens (aka work with native device pixels instead of css pixels)