Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate documentation in EllipsoidGraphics. #8248

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

shunter
Copy link
Contributor

@shunter shunter commented Oct 3, 2019

Some of the constructor parameters were incorrectly duplicated in #5995.

@cesium-concierge
Copy link

Thanks for the pull request @shunter!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@emackey
Copy link
Contributor

emackey commented Oct 11, 2019

Test fail is unrelated to this branch. Thanks @shunter.

@emackey emackey merged commit da3675e into master Oct 11, 2019
@emackey emackey deleted the fixEllipsoidGraphicsDoc branch October 11, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants