Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async pick explicit rendering fix #8283

Merged
merged 3 commits into from
Oct 21, 2019
Merged

Conversation

lilleyse
Copy link
Contributor

Fixes #8281

I could not trigger the problem by modifying the existing clamping demo but this is still a good fix regardless. More details in #8281.

Sandcastle

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

Copy link
Contributor

@IanLilleyT IanLilleyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lilleyse!

@IanLilleyT IanLilleyT merged commit 1d40b91 into master Oct 21, 2019
@IanLilleyT IanLilleyT deleted the async-pick-explicit-rendering-fix branch October 21, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Async pick/sample functions don't work with explicit rendering
3 participants