Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cameraUnderground property to the Scene #8765

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Add cameraUnderground property to the Scene #8765

merged 3 commits into from
Apr 17, 2020

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Apr 17, 2020

No description provided.

@cesium-concierge
Copy link

Thanks for the pull request @fredj!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

1 similar comment
@cesium-concierge
Copy link

Thanks for the pull request @fredj!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

Thanks @fredj! I was about to make this change in #8726 after sending you that sandcastle but you beat me to it.

@lilleyse lilleyse merged commit dcd5bfc into CesiumGS:master Apr 17, 2020
@fredj fredj deleted the cameraUnderground_scene branch April 20, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredj @cesium-concierge @lilleyse