Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cloud styling fixes #8785

Merged
merged 6 commits into from
May 13, 2020
Merged

Point cloud styling fixes #8785

merged 6 commits into from
May 13, 2020

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Apr 22, 2020

${feature.propertyName} and ${feature['propertyName']} syntax now works for point clouds using the GLSL styling backend. It was an oversight in getShaderExpression and required just a few small changes.

The bigger change here is supporting feature properties with non-alphanumeric characters, like ${feature['temperature value 😀']}. The shader was using the property name as-is which doesn't compile if the name has spaces or unicode characters. Now the shader attribute is named with a unique id.

Local sandcastle

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Apr 23, 2020

Awesome! Thanks for the quick fix @lilleyse!

@sanjeetsuhag
Copy link
Contributor

@lilleyse It would be good to have tests for handling properties with spaces and Unicode characters

@lilleyse
Copy link
Contributor Author

Added a test and confirmed the test fails in master. @sanjeetsuhag do you have other feedback?

@mramato
Copy link
Contributor

mramato commented May 13, 2020

Would love to see this go into the next release. @sanjeetsuhag is there anything else you're looking for here?

@sanjeetsuhag
Copy link
Contributor

Code, sandcastle and test look good. Thanks @lilleyse!

@sanjeetsuhag sanjeetsuhag reopened this May 13, 2020
@sanjeetsuhag sanjeetsuhag merged commit 1e8b680 into master May 13, 2020
@mramato mramato deleted the feature-syntax branch May 13, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants