Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8464 .
See my comment over there explaining the issue and the solution.
The issue is actually in all rhumb-arc polylines. This should crush your sancastle with a
normalized result is not a number
error:As I wrote in that comment, I think a better solution would be to compute the number of points for each segment only once and pass it over to
generateCartesianRhumbArc
. However, I was a bit hesitant to make such a change, because that would break the similarity togenerateCartesianArc
.Ideally, I think both
generateCartesianArc
andgenerateCartesianRhumbArc
can do with some refactoring, for your consideration.