Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed depth plane for orthographic #8858

Merged
merged 4 commits into from
May 19, 2020
Merged

Fixed depth plane for orthographic #8858

merged 4 commits into from
May 19, 2020

Conversation

IanLilleyT
Copy link
Contributor

This PR fixes the polyline subissue in #5110 (which is not actually related to ground primitives).

Two fixes went into this

  1. Keep the orthographic depth plane centered at the ellipsoid center instead of moving closer to the camera.
  2. In the depth plane shader when intersecting the ellipsoid, need to shoot rays from the near plane all in the same direction.

Before Sandcastle (look at the left edge of the globe)

Screen Shot 2020-05-15 at 11 58 09 PM

After Sandcastle

Screen Shot 2020-05-15 at 11 58 16 PM

@cesium-concierge
Copy link

Thanks for the pull request @IanLilleyT!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@he-hesce
Copy link

he-hesce commented May 16, 2020

@lilleyse: Would like to see this merged and included in 1.70.

Thanks to @IanLilleyT for addressing this critical issue #5110 for us. 👍 🥇

@mramato
Copy link
Contributor

mramato commented May 16, 2020

Does this fix #8653?

@IanLilleyT
Copy link
Contributor Author

@mramato: Nope, that bug is unrelated to depth plane, I added more info there: #8653.

@lilleyse
Copy link
Contributor

Looks good for this sandcastle too: sandcastle

master
before
orthoDepthPlaneFix
after

@lilleyse
Copy link
Contributor

Code looks good 👍

@lilleyse lilleyse merged commit 1320f6d into master May 19, 2020
@lilleyse lilleyse deleted the orthoDepthPlaneFix branch May 19, 2020 01:08
@he-hesce
Copy link

Thanks @lilleyse! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants