Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct removing duplicate positions from WallGeometry #8952

Merged
merged 2 commits into from
Jun 13, 2020

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Jun 12, 2020

Fixes #8842

WallGeometry was missing a call to arrayRemoveDuplicates that we created to standardize the epsilon distance at which to remove duplicate positions.

Also updated the lat/lon epsilon check to use EPSILON10. We initially undershot with EPSILON6, then #1483 overshot and changed it to EPSILON14, but EPSILON10 is what we've standardized on in arrayRemoveDuplicates and our other geometry duplicate check functions.

@cesium-concierge
Copy link

Thanks for the pull request @hpinkos!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato mramato merged commit e59a8a9 into master Jun 13, 2020
@mramato mramato deleted the remove-duplicates-wall branch June 13, 2020 01:23
@mramato
Copy link
Contributor

mramato commented Jun 13, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out duplicate points for Wall Geometry
3 participants