Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(p2p): regression test for kademlia #4622

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Aug 6, 2024

Summary of changes

Part of #4602

This PR adds a compatibility regression test for the p2p Kademlia module between rust-libp2p and go-libp2p

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review August 6, 2024 05:04
@hanabi1224 hanabi1224 requested a review from a team as a code owner August 6, 2024 05:04
@hanabi1224 hanabi1224 requested review from lemmih and LesnyRumcajs and removed request for a team August 6, 2024 05:04
@LesnyRumcajs
Copy link
Member

@hanabi1224 Are those tests invoked in the CI, or run only manually?

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Aug 6, 2024

@hanabi1224 Are those tests invoked in the CI, or run only manually?

@LesnyRumcajs They run in CI. See https:/ChainSafe/forest/actions/runs/10264936529/job/28400043007?pr=4622#step:6:2059

PASS [   0.045s] forest-filecoin libp2p::discovery::tests::kademlia_test

Copy link
Contributor

@lemmih lemmih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I didn't review the Golang code.

@hanabi1224 hanabi1224 added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit f7e62ec Aug 6, 2024
30 checks passed
@hanabi1224 hanabi1224 deleted the hm/kad-regression-test branch August 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants