Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦀 bug(?): Multi-select breaking in System Setup & Utilities tabs #712

Open
4 tasks done
adamperkowski opened this issue Oct 1, 2024 · 5 comments · May be fixed by #719
Open
4 tasks done

🦀 bug(?): Multi-select breaking in System Setup & Utilities tabs #712

adamperkowski opened this issue Oct 1, 2024 · 5 comments · May be fixed by #719
Labels
bug Something isn't working rust Pull requests that update Rust code

Comments

@adamperkowski
Copy link
Contributor

adamperkowski commented Oct 1, 2024

This is not a bug. This is intentional behaviour.

I'm keeping this issue open for conversation about this.

Describe the bug

See the video below.

To Reproduce

Steps to reproduce the behavior:

  1. Launch linutil
  2. Enable multi-select mode
  3. Change tabs to System Setup or Utilities
  4. multi-select breaks :'(

Additional context

2024-10-01.03-00-08.mp4

Sorry for crappy internet, recorded this on my laptop.

Checklist

  • I checked for duplicate issues.
  • I checked already existing discussions.
  • This issue is not included in the roadmap.
  • This issue is present on both stable and development branches.
@adamperkowski adamperkowski added the bug Something isn't working label Oct 1, 2024
@github-actions github-actions bot added the rust Pull requests that update Rust code label Oct 1, 2024
@lj3954
Copy link
Contributor

lj3954 commented Oct 1, 2024

This is intentional behaviour, look in the tab data for those two. Why was it done? I'm not really sure. @jeevithakannan2 would have to help you out with that.

@adamperkowski
Copy link
Contributor Author

This is intentional behaviour, look in the tab data for those two. Why was it done? I'm not really sure. @jeevithakannan2 would have to help you out with that.

You're right. I should've looked. I'll update the issue.
I think I understand that we may not want multi-select in "more important" sections or whatever but

  1. the average user doesn't know that their whole "queue" is just going to disintegrate like that
  2. only some of the scripts in System Setup for example are really "dangerous". Most of Utilities scripts are very easily revertable

I think this should be removed or multi-select should be refactored.

@adamperkowski adamperkowski changed the title bug: Multi-select breaking in System Setup & Utilities tabs ~bug~: Multi-select breaking in System Setup & Utilities tabs Oct 1, 2024
@adamperkowski adamperkowski changed the title ~bug~: Multi-select breaking in System Setup & Utilities tabs bug(?): Multi-select breaking in System Setup & Utilities tabs Oct 1, 2024
@jeevithakannan2
Copy link
Contributor

jeevithakannan2 commented Oct 1, 2024

I am working on disabling multi selection for individual scripts. Will create a PR in a couple of days. Which will also not clear the queue.

@adamperkowski
Copy link
Contributor Author

Okay. Make sure to link the PR. I'll keep this issue open.

@jeevithakannan2
Copy link
Contributor

Okay !!

@jeevithakannan2 jeevithakannan2 linked a pull request Oct 1, 2024 that will close this issue
12 tasks
@adamperkowski adamperkowski changed the title bug(?): Multi-select breaking in System Setup & Utilities tabs 🦀 bug(?): Multi-select breaking in System Setup & Utilities tabs Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants