Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mybash deps check is bugged #750

Open
4 tasks done
cartercanedy opened this issue Oct 3, 2024 · 9 comments · May be fixed by #762 or #763
Open
4 tasks done

Mybash deps check is bugged #750

cartercanedy opened this issue Oct 3, 2024 · 9 comments · May be fixed by #762 or #763
Labels
bug Something isn't working script Pull requests that update scripts

Comments

@cartercanedy
Copy link
Contributor

cartercanedy commented Oct 3, 2024

Describe the bug

mybash-setup.sh uses command_exists "bash" "bash-completion" ... as if it fails if one of the dependencies does not exist, but this won't work as written. Also, bash-completion and fontconfig aren't executables, so the check would always fail if it did work as intended...

To Reproduce

  1. run the bash prompt script
  2. install fails if deps aren't installed, most likely to happen on fresh distro installs

Screenshots

If applicable, add screenshots to help explain your problem.

Checklist

  • I checked for duplicate issues.
  • I checked already existing discussions.
  • This issue is not included in the roadmap.
  • This issue is present on both stable and development branches.
@cartercanedy cartercanedy added the bug Something isn't working label Oct 3, 2024
@cartercanedy
Copy link
Contributor Author

/label 'script'

@github-actions github-actions bot added the script Pull requests that update scripts label Oct 3, 2024
@cartercanedy cartercanedy mentioned this issue Oct 3, 2024
6 tasks
@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Oct 4, 2024

you're wrong, the ! means if even all are installed it will still install, same for if none are found or if only 1 / 2 are found

can not reproduce this issue as well. there is really no issue here

@cartercanedy
Copy link
Contributor Author

It is an issue, it's reproducible using both openSUSE and Kali

@cartercanedy
Copy link
Contributor Author

same for if none are found or if only 1 / 2 are found

command -v <arg1> <arg2>... will only evaluate <arg1> without examining the rest of the arguments, which is problematic for several reason, namely fc-cache from fontconfig, which is not installed on headless distros like kali-headless and others

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Oct 4, 2024

same for if none are found or if only 1 / 2 are found

command -v <arg1> <arg2>... will only evaluate <arg1> without examining the rest of the arguments, which is problematic for several reason, namely fc-cache from fontconfig, which is not installed on headless distros like kali-headless and others

read what i said please

@cartercanedy
Copy link
Contributor Author

cartercanedy commented Oct 5, 2024

@nnyyxxxx I don't understand why all of my contributions have been met with such fierce criticism on your part.

You're free to say that I'm wrong, but the fundamental issue still remains, regardless.

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Oct 5, 2024

@nnyyxxxx I don't understand why all of my contributions have been met with such fierce criticism on your part.

You're free to say that I'm wrong, but the fundamental issue still remains, regardless.

i cant reproduce the issue you're having man... all that PR is doing is bloating up the func, if you want a clear-cut solution to your nonexistent problem then remove every other dep from the command_exists var

@cartercanedy
Copy link
Contributor Author

@nnyyxxxx I don't understand why all of my contributions have been met with such fierce criticism on your part.

You're free to say that I'm wrong, but the fundamental issue still remains, regardless.

i cant reproduce the issue you're having man... all that PR is doing is bloating up the func, if you want a clear-cut solution to your nonexistent problem then remove every other dep from the command_exists var

Ok, close the issue then, if you're insisting that there's no issue

@cartercanedy
Copy link
Contributor Author

cartercanedy commented Oct 5, 2024

These are the exact steps to reproduce:

  1. Using WSL, install openSUSE Leap 15.6 viawsl --install -d openSUSE-Leap-15.6 --web-download and complete out-of-box setup wizard
  2. Install cargo + git + gcc with zypper via sudo zypper install cargo gcc git
  3. clone main branch of LinUtil via git clone --depth 1 https:/christitustech/linutil.git
  4. Run with cargo r
  5. Attempt to run Bash prompt script, which fails when attempting to invoke fc-cache

@nnyyxxxx nnyyxxxx linked a pull request Oct 5, 2024 that will close this issue
1 task
@jeevithakannan2 jeevithakannan2 linked a pull request Oct 5, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working script Pull requests that update scripts
Projects
None yet
2 participants