Refactor code and add test #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h42zhu
force-pushed
the
add-unit-tests
branch
from
47df547
to
002ad06
Compare
sulami
suggested changes
Dec 6, 2022
h42zhu
force-pushed
the
add-unit-tests
branch
7 times, most recently
from
2381364
to
916a5cc
Compare
h42zhu
force-pushed
the
add-unit-tests
branch
from
916a5cc
to
5d489fd
Compare
h42zhu
force-pushed
the
add-unit-tests
branch
from
2d6c1ab
to
c726629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
create-parameters.pycode to be more functional and added a test to make sure the orb runs without errors. Testing for correctness requires more granular unit tests, which is generally omitted in other orbs.