Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KiCAD 8 #83

Merged
merged 5 commits into from
May 2, 2024
Merged

KiCAD 8 #83

merged 5 commits into from
May 2, 2024

Conversation

ClemensElflein
Copy link
Owner

Need to wait for a KiBOT release before merging this.

Also @rfvermut please double check. There wasn't much to change, I did the following changes to solve DRC issues:

  • For the GND fills on front and back, I went from 1mm thermal spokes to 0.4, since higher values gave errors with solder jumpers
  • I synchronized schematic with board, since there was a schematic parity warning (SW1 had different flags in schematic and board).

@ClemensElflein ClemensElflein marked this pull request as draft March 10, 2024 17:13
@vermut
Copy link
Contributor

vermut commented Apr 1, 2024

kicad 8 ALREADY? I've just finished migrating to v7!

Copy link
Contributor

@vermut vermut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibot released, testing:

PS C:\Users\Vermut\IdeaProjects\OpenMower\OpenMower> docker run --rm -ti -v .:/app -w /app/Hardware/OpenMowerMainboard ghcr.io/inti-cmnb/kicad8_auto k
ibot


Using config file: OpenMowerMainboard.kibot.yaml
WARNING:(W044) More than one SCH file found in `.`.
  Using ./OpenMowerMainboard.kicad_sch if you want to use another use -e option. (kibot - kiplot.py:833)
- Running the DRC
- Running the ERC
ERROR:ERC returned 1 (kibot.gs - gs.py:814)

Will investigate.

@@ -33,8 +33,8 @@
#define UI_GET_VERSION_CYCLETIME 5000 // cycletime for UI Get_Version request (UI available check)
#define UI_GET_VERSION_TIMEOUT 100 // timeout for UI Get_Version response (UI available check)

#define TILT_EMERGENCY_MILLIS 50000 // Time for a single wheel to be lifted in order to count as emergency. This is to filter uneven ground.
#define LIFT_EMERGENCY_MILLIS 1000 // Time for both wheels to be lifted in order to count as emergency. This is to filter uneven ground.
#define TILT_EMERGENCY_MILLIS 2500 // Time for a single wheel to be lifted in order to count as emergency. This is to filter uneven ground.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, my bad

@vermut
Copy link
Contributor

vermut commented Apr 2, 2024

@ClemensElflein that's something local to my machine. Change v2_k7 to v2_k8 and try

@vermut
Copy link
Contributor

vermut commented Apr 27, 2024

@ClemensElflein please apply this and it should work:

Index: Hardware/OpenMowerMainboard/OpenMowerMainboard.kibot.yaml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/Hardware/OpenMowerMainboard/OpenMowerMainboard.kibot.yaml b/Hardware/OpenMowerMainboard/OpenMowerMainboard.kibot.yaml
--- a/Hardware/OpenMowerMainboard/OpenMowerMainboard.kibot.yaml	(revision b4010d3258f7d66564e14d05b47519f97fbcf5f8)
+++ b/Hardware/OpenMowerMainboard/OpenMowerMainboard.kibot.yaml	(date 1714227879422)
@@ -2,8 +2,8 @@
   version: 1
 
 preflight:
-  run_drc: true
-  run_erc: true
+  drc: true
+  erc: true
 
   filters:
     - filter: SIP32509DT has 2 VOUTs
Index: .github/workflows/ci.yaml
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
--- a/.github/workflows/ci.yaml	(revision b4010d3258f7d66564e14d05b47519f97fbcf5f8)
+++ b/.github/workflows/ci.yaml	(date 1714228192974)
@@ -10,7 +10,7 @@
       - uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - uses: INTI-CMNB/KiBot@v2_k7
+      - uses: INTI-CMNB/KiBot@v2_k8
         with:
           config: Hardware/OpenMowerMainboard/OpenMowerMainboard.kibot.yaml
           board: Hardware/OpenMowerMainboard/OpenMowerMainboard.kicad_pcb

@ClemensElflein ClemensElflein marked this pull request as ready for review April 27, 2024 19:59
@vermut
Copy link
Contributor

vermut commented May 2, 2024

checks are green. let's merge?

@ClemensElflein ClemensElflein merged commit f55300b into main May 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants