Fix bug with plotting multiple figures #121
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 11 11
Lines 1071 1071
=======================================
Hits 1051 1051
Misses 20 20 ☔ View full report in Codecov by Sentry. |
|
@AlexisRenchon can you have a look at this? I don't know if it has side effects |
this looks great to me, it's better to name fig and axis and clearly add content to them. I know that a while ago (years ago) it was not possible to have multiple figure open in Makie (e.g., fig and fig1 like your test), maybe they added that by now, which would be great... that was an annoying limitation... did the test pass? |
For the functions `_geomakie_plot_on_globe!`, `heatmap2D!`, and `line_plot1D!`, you cannot initialize multiple figures and use these functions afterward as you get the error "LoadError: There is no current axis to plot into". To fix this, we initialize an `Axis` object in the function and use that for plotting.
Yes, the tests passed. |
closes #112 - For the functions
_geomakie_plot_on_globe!,heatmap2D!, andline_plot1D!, you cannot initialize multiple figures and use these functions afterward as you get the error "LoadError: There is no current axis to plot into". To fix this, we initialize anAxisobject in the function and use that for plotting.