-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make slider interaction work for Makie Field recipe #940
Conversation
Added basic GeoMakie example: |
Uncovered this bug while switching between the fields: |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
6a70e36
to
c1c8f60
Compare
bors r+ |
Use lift to visualize a changing field.
The updated code is designed in a way, that the mesh doesn't need recalculating if the sphere itself doesn't change, so only color values will get updated, which is much more efficient.
Also, started using the Makie native types to avoid conversions.
With this PR, a basic slider example works: