Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify jacobian/tendency naming convention #660

Closed
Tracked by #135
juliasloan25 opened this issue Jun 13, 2024 · 0 comments · Fixed by #685
Closed
Tracked by #135

Unify jacobian/tendency naming convention #660

juliasloan25 opened this issue Jun 13, 2024 · 0 comments · Fixed by #685
Assignees
Labels
enhancement New feature or request

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Jun 13, 2024

Is your feature request related to a problem? Please describe.
We have the function imp_tendency!, which calls update_aux!, update_boundary_fluxes!, and compute_imp_tendency! (where the actual tendency computation is done). We also have the explicit analogs.

Similarly, we have tendency_jacobian!, which calls update_aux!, update_boundary_fluxes!, and update_jacobian! (where the actual tendency computation is done).

We should unify our naming so the similarities between these functions are more clear. For example:
update_jacobian -> compute_jacobian
tendency_jacobian -> jacobian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants