Change outdir and savedir to not use pkgdir #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All uses of pkgdir to specify save or output paths now use generate_output_path.
Sbozzolo
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Can you please add some docs somewhere about the expected output structure (so that people know where they should look for files)?
It is described here: https://clima.github.io/ClimaUtilities.jl/dev/outputpathgenerator/
We use ActiveLinkStyle
imreddyTeja
force-pushed
the
tr/replace-pkgdir
branch
from
92011eb
to
7cb311a
Compare
Sbozzolo
reviewed
Oct 7, 2024
Sbozzolo
reviewed
Oct 7, 2024
Comment on lines
+39
to
+42
| the ClimaLand.jl directory. If run from the ClimaLand.jl directory, then the outputs of an experiment will be saved into | ||
| the same directory the experiment script is found in. Otherwise the outputs will be saved to | ||
| the path of the script relative to the ClimaLand.jl directory. |
There was a problem hiding this comment.
Why do they have to be run from the ClimaLand.jl directory?
|
You also have to update the artifact paths in the buildkite pipelines |
Co-authored-by: Gabriele Bozzola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of pkgdir to specify save or output paths now use generate_output_path.
Purpose
Closes #545
To-do
Content