Fix serialization for slices of OrderedMap/IterableOrderedMap (#1365) #1418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Array column handling is special-cased for nested
Array(Array(Array(Whatever)))
cases.If you want to traverse nested pointers to slices or slices cast to
any
, you have to special case as well, as was done in #1350.This broke the inserts for slices of
IterableOrderedMap
, as the new code unwrapped one pointer too much.This PR fixes #1350Օ by moving interface/pointer unwrapping to the beginning of the nesting loop.
Checklist