[client-v2] primitive reading into pojo #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzitnik
reviewed
Sep 17, 2024
| @@ -91,6 +89,10 @@ public class QueryTests extends BaseIntegrationTest { | |||
|
|
|||
| private boolean usePreallocatedBuffers = false; | |||
|
|
|||
| static { | |||
| // System.setProperty("org.slf4j.simpleLogger.defaultLogLevel", "DEBUG"); | |||
There was a problem hiding this comment.
ok. this is only for current development. but will move into env settings on local
There was a problem hiding this comment.
|
Do we support POJO with types of Long, Integer, Short, and more class |
We do but with 1-to-1 match. But with primitives it should be easier to handle. |
|
mzitnik
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current implementation reads all values into objects even it can be done using primitive types. It was done to simplify code, but it may be not good for memory consumption.
Current PR:
Checklist
Delete items not relevant to your PR: