New JDBC driver #747
Merged
New JDBC driver #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
Rooting for this feature to go live soon.... Native array support would be very very useful |
Thanks but native array support is not a new feature - it's been there for a while... |
This was
linked to
issues
Nov 22, 2021
This was referenced Nov 24, 2021
This was
linked to
issues
Nov 28, 2021
|
|
|
|
|
|
|
Key features of the new JDBC driver are ready and being tested in local for weeks. It's time to get the pull request merged into develop for creating test builds. I'll create a separate PR to complete below features:
|
This was
linked to
issues
Nov 29, 2021
This was referenced Nov 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gave up most changes in #743 because 1) mixed APIs are confusing; 2) risky to upgrade.
This pull request is to add a brand new JDBC driver
com.clickhouse.jdbc.ClickHouseDriverwith minimum changes to legacy code, for better backward compatibility and visibility of what's coming next.TODOs:
jdbc:clickhouse:andjdbc:ch:as prefixhttp, sojdbc:ch://localhostis same asjdbc:ch:http://localhostformat: RowBinaryWithNamesAndTypescom.clickhouse.jdbccom.clickhouse.jdbc.parserclickhouse-http-clientand make it default provider for the new driverclickhouse-client:clickhouse-grpc-client) for JDBC driverDatabaseMetaData.getIndexInfoDatabaseMetaData.getSchemaslog_comment(in system.query_log)custom_http_headers: "User-Agent=New Client, X-Forwarded-For=1\,2"custom_http_params: "max_execution_time=30, mutations_sync=2"jdbc_compliantoption to enable:update a set c1=1 where c2=2->alter table a update c1=1 where c2=2 settings mutations_sync=1delete from a->truncate table adelete from a where c1=1->alter table a delete where c1=1 settings mutations_sync=1select * from system.query_log limit 5 format JSONEachRow) - only works for text format* ternary operator support -
select 1 ? 'a' : 'b', 2 ? (select 1) : 2, ?only contains one parameter(the last?)* type inferring from input function and maybe magic comments?
* parameter templating based on first value?
clickhouse-grpc-clientandclickhouse-http-clientAggregateFunctionClickHouseValueinterface and use InputStream/OutputStream instead of in-memory byte arrayUpdate:
performance test on my laptop
50 concurrent users, each issue query
select * from numbers(10000)for 10,000 times; connection pool size is 50,select 1is used to validate connection.Note: JMeter was used for the testing(close and re-open for each run).