Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/templatestorage #1298

Closed

Conversation

DasBabyPixel
Copy link
Contributor

Motivation

Downloading files from the Wrapper via the TemplateStorage has a synchronization bug
More information in #1294

Modification

Most important change: Moved the RemoteTemplateStorage from the driver to the wrapper
Unless there is some future API planned, this should be fine because the RemoteTemplateStorage is only used in the wrapper and as far as I understand it remote storages from node to node are not allowed.

Otherwise in RemoteTemplateStorage I had to add a reference to the TemplateStorageCallbackListener which modifies the creation all the way up to the Wrapper class

Most of the logic itself is in the TemplateStorageCallbackListener, we could refactor the logic to somewhere else but my opinion is: what's the point?

I also modified temporary file creation. This could be left out, but it really is smarter not give the possibility to overwrite temporary files someone else created

Result

the TemplateStorage API works again

Other context

Fixes #1294

@derklaro
Copy link
Member

derklaro commented Jul 1, 2024

Hey, thanks for the PR and sorry for the late reply on this one. I've fixed this issue in the network refactor branch and it will probably be included in the next release: 8ea6b75

@derklaro derklaro closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temp folder on wrapper does not exist and synchronization bug in templatestorage
2 participants