Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module loading improvements #1302

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from

Conversation

DasBabyPixel
Copy link
Contributor

Motivation

#1301
Also there is no cyclic dependency detection (not included in issue)

Modification

Rewrote DefaultModuleProvider#loadAll() to respect dependencies
Changed methods in ModuleDependencyUtil to use ModuleConfiguration rather than ModuleWrapper to allow using the methods without instantiating any classes of the module
Modified tests to work again after changes to ModuleDependencyUtil
Added an exception for cyclic dependencies.
I haven't added a test for cyclic dependency detection, because there wasn't a nice way to do so

Result

Fixes modules being loaded onto the classpath before their dependency modules are loaded.
There is now a cyclic dependency detection.

Other context

Fixes #1301
I tested the PR with my demo project (master and cyclic branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module Dependency load order not respected
1 participant