Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signs checked configuration templates instead of installed templates #1523

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

fix: signs checked configuration templates instead of installed templates #1523

wants to merge 1 commit into from

Commits on Oct 7, 2024

  1. fix: signs checked configuration templates instead of installed templ… 

    …ates

### Motivation
The 3.5 documentation for signs (https://cloudnetservice.eu/de/docs/next/modules/signs) says: "The tags can even be targeted to specific groups with a template path limitation, which will then only show services with the specified template." and I think that should still be valid for CloudNet 4.0. The problem is that the current implementation checks for templates in the configuration, which doesn't necessarily match the installed templates (e.x. using the smart module template configuration can change that).

### Modification
Changed the getter for templates to only get installed templates in the templatePath check.

### Result
Now, only templates that are actually installed will make a service show up on signs with the specified templatePath. This is also consistent with the templates that are displayed when the service command is used to look up its information.
    @Slxvly
    Slxvly committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    d4d18e5 View commit details
    Browse the repository at this point in the history